Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencyManagement #2660

Merged
merged 27 commits into from
May 14, 2019
Merged

update dependencyManagement #2660

merged 27 commits into from
May 14, 2019

Conversation

IanCao
Copy link
Contributor

@IanCao IanCao commented May 14, 2019

Please answer these questions before submitting pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues


Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

@IanCao IanCao requested review from wu-sheng and peng-yongsheng and removed request for wu-sheng May 14, 2019 03:05
@wu-sheng wu-sheng added this to the 6.2.0 milestone May 14, 2019
@wu-sheng wu-sheng added the backend OAP backend related. label May 14, 2019
@IanCao
Copy link
Contributor Author

IanCao commented May 14, 2019

@wu-sheng @peng-yongsheng Hi, i have added those third-party libraries into oap's dependency manager according to the current state

@coveralls
Copy link

coveralls commented May 14, 2019

Coverage Status

Coverage decreased (-0.002%) to 16.422% when pulling 24d66f1 on IanCao:master into e07172b on apache:master.

@peng-yongsheng
Copy link
Member

@IanCao Thank you very much, I will merge this into the master after compile finished. cc @wu-sheng

@wu-sheng
Copy link
Member

@peng-yongsheng If this versions of libs are the current ones, merge this please.

@peng-yongsheng
Copy link
Member

@peng-yongsheng If this versions of libs are the current ones, merge this please.

I had been compared them with the 6.1.0 release library. That all right.

@peng-yongsheng peng-yongsheng merged commit b4ee1f1 into apache:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants